[webkit-reviews] review denied: [Bug 47121] need way to measure size of JITed ARM code : [Attachment 69697] Patch adds function to dump generated code size before and after branch compaction.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied David Goodwin
<david_goodwin at apple.com>'s request for review:
Bug 47121: need way to measure size of JITed ARM code
https://bugs.webkit.org/show_bug.cgi?id=47121

Attachment 69697: Patch adds function to dump generated code size before and
after branch compaction.
https://bugs.webkit.org/attachment.cgi?id=69697&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69697&action=review

This patch looks good, but I think it's worth doing those minor style
improvements before landing.

> JavaScriptCore/assembler/LinkBuffer.h:288
> +	   static unsigned int linkCnt = 0;
> +	   static unsigned int totalInitialSize = 0, totalFinalSize = 0;

WebKit style is just "unsigned", not "unsigned int".

> JavaScriptCore/assembler/LinkBuffer.h:289
> +	   linkCnt++;

WebKit style is to use full words in names instead of abbreviations:
"linkCount".