[webkit-reviews] review granted: [Bug 47113] Move SharedGraphicsContext3D from ChromeClient to Page : [Attachment 69695] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 4 17:03:41 PDT 2010
James Robinson <jamesr at chromium.org> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 47113: Move SharedGraphicsContext3D from ChromeClient to Page
https://bugs.webkit.org/show_bug.cgi?id=47113
Attachment 69695: Patch
https://bugs.webkit.org/attachment.cgi?id=69695&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69695&action=review
Looks fine to me.
> WebCore/page/Page.cpp:69
> +#if ENABLE(ACCELERATED_2D_CANVAS)
> +#include "SharedGraphicsContext3D.h"
> +#endif
Normally conditionally included headers are put after the main list of headers,
not in the middle.
More information about the webkit-reviews
mailing list