[webkit-reviews] review denied: [Bug 46943] [chromium] getData('text/uri-list') should return the same thing that was passed to setData('text/uri-list') : [Attachment 69713] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 4 16:49:03 PDT 2010
Tony Chang <tony at chromium.org> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 46943: [chromium] getData('text/uri-list') should return the same thing
that was passed to setData('text/uri-list')
https://bugs.webkit.org/show_bug.cgi?id=46943
Attachment 69713: Patch
https://bugs.webkit.org/attachment.cgi?id=69713&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69713&action=review
The code looks OK but I would like to see more tests.
>
LayoutTests/editing/pasteboard/script-tests/dataTransfer-setData-getData.js:103
> + test("text/uri-list", "#
comment\r\nhttp://test.com\r\nhttp://check.com",
> + "URL", "http://test.com/");
Can you add some more test cases like setting URL and getting text/uri-list?
What about setting a text/uri-list with comments but no urls and getting URL?
What about setting a URL with multiple urls and getting with URL?
More information about the webkit-reviews
mailing list