[webkit-reviews] review granted: [Bug 47127] Added event onwebkitspeechchange and invoke on new speech input results. : [Attachment 69711] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 4 16:26:52 PDT 2010
Jeremy Orlow <jorlow at chromium.org> has granted Satish Sampath
<satish at chromium.org>'s request for review:
Bug 47127: Added event onwebkitspeechchange and invoke on new speech input
results.
https://bugs.webkit.org/show_bug.cgi?id=47127
Attachment 69711: Patch
https://bugs.webkit.org/attachment.cgi?id=69711&action=review
------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69711&action=review
r=me assuming you fix the nits
> WebCore/html/HTMLInputElement.cpp:1214
> + } else if (attr->name() == onwebkitspeechchangeAttr) {
no {}s
> WebCore/html/HTMLInputElement.idl:104
> +#if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C
Why do this?
More information about the webkit-reviews
mailing list