[webkit-reviews] review denied: [Bug 47024] Update Angle interface from 100 to 101 for chromium --in-process-webgl : [Attachment 69708] proposed patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Alok Priyadarshi
<alokp at chromium.org>'s request for review:
Bug 47024: Update Angle interface from 100 to 101 for chromium
--in-process-webgl
https://bugs.webkit.org/show_bug.cgi?id=47024

Attachment 69708: proposed patch
https://bugs.webkit.org/attachment.cgi?id=69708&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69708&action=review

This generally looks good. One minor formatting comment; please fix and submit
a new patch. Also, please file a bug about updating the version of ANGLE
checked in to WebKit. It would be really helpful if you could update that
version as well so that Safari and Chromium stay in sync.

> WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:1426
> +		   &resources.MaxVertexUniformVectors);

There's no 80-column limit in the WebKit coding style. I think these looked
cleaner as one-line expressions. Please re-format them.