[webkit-reviews] review granted: [Bug 47011] Add AudioUtilities files : [Attachment 69682] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 4 15:10:34 PDT 2010
Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 47011: Add AudioUtilities files
https://bugs.webkit.org/show_bug.cgi?id=47011
Attachment 69682: Patch
https://bugs.webkit.org/attachment.cgi?id=69682&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69682&action=review
Looks fine overall. One small comment; up to you whether to make this change
IMO.
> WebCore/platform/audio/AudioUtilities.cpp:37
> + return pow(10.0, 0.05 * decibels);
Strictly, this .0 and the others throughout this file are not necessary
according to WebKit style ("Floating point literals" on
http://webkit.org/coding/coding-style.html ).
More information about the webkit-reviews
mailing list