[webkit-reviews] review granted: [Bug 47112] Convert addOverhangingFloats and addIntrudingFloats to be block-flow-aware. : [Attachment 69688] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 4 15:08:18 PDT 2010
mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 47112: Convert addOverhangingFloats and addIntrudingFloats to be
block-flow-aware.
https://bugs.webkit.org/show_bug.cgi?id=47112
Attachment 69688: Patch
https://bugs.webkit.org/attachment.cgi?id=69688&action=review
------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=69688&action=review
> WebCore/rendering/RenderBlock.h:393
> int left() const { return m_frameRect.x(); }
> int right() const { return m_frameRect.right(); }
> int top() const { return m_frameRect.y(); }
Should these accessors ASSERT(m_isPlaced)?
More information about the webkit-reviews
mailing list