[webkit-reviews] review denied: [Bug 46528] Add BiquadDSPKernel files : [Attachment 68770] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 46528: Add BiquadDSPKernel files
https://bugs.webkit.org/show_bug.cgi?id=46528

Attachment 68770: Patch
https://bugs.webkit.org/attachment.cgi?id=68770&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68770&action=review

Code generally looks good; one change, plus please update the copyright notice.


> WebCore/webaudio/BiquadDSPKernel.h:56
> +    BiquadProcessor* m_biquadProcessor;

Please remove this weak pointer and instead provide a helper method which
downcasts the superclass's pointer. Having multiple pointers in multiple
classes all pointing to the same storage makes understanding the lifetime
difficult. Also, the superclass doesn't maintain an OwnPtr; who actually owns
the AudioDSPKernelProcessor* in the superclass?