[webkit-reviews] review granted: [Bug 47098] dump-as-markup conversion: editing/execCommand/format-block-with-braces.html and format-block.html : [Attachment 69666] Patch

Mon Oct 4 15:05:35 PDT 2010

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 47098: dump-as-markup conversion:
editing/execCommand/format-block-with-braces.html and format-block.html
https://bugs.webkit.org/show_bug.cgi?id=47098

Attachment 69666: Patch
https://bugs.webkit.org/attachment.cgi?id=69666&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69666&action=review

> LayoutTests/editing/execCommand/format-block-with-braces.html:3
> +<!DOCTYPE html>
> +<html>
> +<body>

I don't know if we have a policy on whether tests should have doctype, html or
body tags.  I think on webkit-dev mjs said he likes the <!DOCTYPE html> tag
because we want to be testing the standards compliant parser.  That said, since
this is an existing test and it didn't have these tags originally, I kind of
think the test should not have these tags (i.e., it's more like a regression
test).

I don't have a strong opinion one way or another and it shouldn't matter at all
for this test, so either is fine with me.