[webkit-reviews] review denied: [Bug 46532] Add LowPass2FilterNode files : [Attachment 69689] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 46532: Add LowPass2FilterNode files
https://bugs.webkit.org/show_bug.cgi?id=46532

Attachment 69689: Patch
https://bugs.webkit.org/attachment.cgi?id=69689&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69689&action=review

Sorry I didn't catch the m_biquadProcessor issue earlier but please change it
here as well as in HighPass2FilterNode.

> WebCore/webaudio/LowPass2FilterNode.cpp:38
> +    m_processor = lowpassFilter.release();

Per below, the weak m_biquadProcessor pointer is very confusing. Please change
this to "m_processor = adoptPtr(...)" and add a helper function to fetch the
processor as a BiquadProcessor.

> WebCore/webaudio/LowPass2FilterNode.h:48
> +    BiquadProcessor* m_biquadProcessor;

This weak pointer makes the lifetime of this object confusing. Make this a
helper function "BiquadProcessor* biquadProcessor()" returning a static_cast of
the result of processor().