[webkit-reviews] review denied: [Bug 46495] Add AudioBasicProcessorNode files : [Attachment 69520] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 46495: Add AudioBasicProcessorNode files
https://bugs.webkit.org/show_bug.cgi?id=46495

Attachment 69520: Patch
https://bugs.webkit.org/attachment.cgi?id=69520&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69520&action=review

This basically looks good; couple of tiny changes. r- for the license text
update discussed offline.

> WebCore/webaudio/AudioBasicProcessorNode.cpp:44
> +    , m_processor(0)

m_processor does not require explicit initialization.

> WebCore/webaudio/AudioBasicProcessorNode.cpp:85
> +	       // FIXME: if we take "tailTime" into account, then we can avoid
calling processor()->process() once the tail dies down.

Is tailTime concretely defined somewhere? If so, please mention where in the
comment; otherwise, change to "tail time".