[webkit-reviews] review denied: [Bug 47113] Move SharedGraphicsContext3D from ChromeClient to Page : [Attachment 69681] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 47113: Move SharedGraphicsContext3D from ChromeClient to Page
https://bugs.webkit.org/show_bug.cgi?id=47113

Attachment 69681: Patch
https://bugs.webkit.org/attachment.cgi?id=69681&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69681&action=review

> WebCore/page/Page.cpp:783
> +	   if (!context)
> +	       return 0;
> +	   m_sharedGraphicsContext3D =
SharedGraphicsContext3D::create(context.release());
> +    }

I think the GraphicsContext3D::create() stuff should be hidden inside of 
static bool SharedGraphicsContext3D::canCreateContext() or something, or maybe
SharedGraphicsContext3D::create() should just return 0 if the context can't be
created.