[webkit-reviews] review denied: [Bug 46532] Add LowPass2FilterNode files : [Attachment 68774] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 46532: Add LowPass2FilterNode files
https://bugs.webkit.org/show_bug.cgi?id=46532

Attachment 68774: Patch
https://bugs.webkit.org/attachment.cgi?id=68774&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68774&action=review

The code looks OK, but I'm marking this r- for the license update as discussed
offline. Please also consider getting the Web Audio spec up to date with this
change before landing it.

> WebCore/webaudio/LowPass2FilterNode.idl:34
> +    ] LowPass2FilterNode : AudioNode {

http://chromium.googlecode.com/svn/trunk/samples/audio/specification/specificat
ion.html#APIOverview-section says that LowPass2FilterNode "would be" a subclass
of AudioNode; I think you should modify the spec to include the API definition
for this class before committing it.