[webkit-reviews] review granted: [Bug 47107] Lazily create activation objects : [Attachment 69674] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 47107: Lazily create activation objects
https://bugs.webkit.org/show_bug.cgi?id=47107

Attachment 69674: Patch
https://bugs.webkit.org/attachment.cgi?id=69674&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69674&action=review

> JavaScriptCore/interpreter/Interpreter.cpp:3173
> -	       callFrame->r(dst) = JSValue(arguments);
> -	       callFrame->r(unmodifiedArgumentsRegister(dst)) =
JSValue(arguments);
> +	       callFrame->r(argumentsRegister) = JSValue(arguments);
> +	       callFrame->r(unmodifiedArgumentsRegister(argumentsRegister)) =
JSValue(arguments);

Since this turned out to be just a bug fix for a bug in a previous arguments
optimization patch, I think you should land it separately with a test case.