[webkit-reviews] review granted: [Bug 47063] Fix broken C++ in PODInterval and PODIntervalTree : [Attachment 69664] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 4 13:39:58 PDT 2010
Kenneth Russell <kbr at google.com> has granted Nico Weber <thakis at chromium.org>'s
request for review:
Bug 47063: Fix broken C++ in PODInterval and PODIntervalTree
https://bugs.webkit.org/show_bug.cgi?id=47063
Attachment 69664: Patch
https://bugs.webkit.org/attachment.cgi?id=69664&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69664&action=review
Code changes look fine; please note minor documentation changes needed.
> WebCore/platform/graphics/gpu/PODInterval.h:64
> +// String string(const T& t);
This should be documented as being static, as is used in the code.
> WebCore/platform/graphics/gpu/PODInterval.h:67
> +// String string(const UserData& t);
static.
> WebCore/platform/graphics/gpu/PODRedBlackTree.h:48
> +// String string(const T& t);
static.
More information about the webkit-reviews
mailing list