[webkit-reviews] review denied: [Bug 46802] Web Inspector: extract consoleMessages related stuff from populateScriptObjects into separate function. : [Attachment 69635] [patch] third iteration.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 46802: Web Inspector: extract consoleMessages related stuff from
populateScriptObjects into separate function.
https://bugs.webkit.org/show_bug.cgi?id=46802

Attachment 69635: [patch] third iteration.
https://bugs.webkit.org/attachment.cgi?id=69635&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69635&action=review

> WebCore/inspector/InspectorController.h:362
> +    bool m_consoleMessagesNotificationsEnabled;

This seems to be a new kind of flag that reflects the front-end state. It
should vanish on front-end disconnect. We already have way too many settings,
states for sessions, application, etc. Should we create structs with
descriptive names for them already?