[webkit-reviews] review granted: [Bug 47097] Generate messages sent to the WebProcess class. : [Attachment 69660] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 47097: Generate messages sent to the WebProcess class.
https://bugs.webkit.org/show_bug.cgi?id=47097

Attachment 69660: Patch
https://bugs.webkit.org/attachment.cgi?id=69660&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69660&action=review

> WebKit2/ChangeLog:13
> +	   * Scripts/webkit2/messages.py:
> +	   * Scripts/webkit2/messages_unittest.py:
> +	   Make this script work for passing a templated type. 

It would be nice to add the names of functions you changed in messages.py.

> WebKit2/WebProcess/WebProcess.cpp:194
> -void WebProcess::setCacheModel(CacheModel cacheModel)
> +void WebProcess::setCacheModel(uint32_t cacheModel)
>  {
> -    if (!m_hasSetCacheModel || cacheModel != m_cacheModel) {
> +    if (!m_hasSetCacheModel || static_cast<CacheModel>(cacheModel) !=
m_cacheModel) {
>	   m_hasSetCacheModel = true;
> -	   m_cacheModel = cacheModel;
> -	   platformSetCacheModel(cacheModel);
> +	   m_cacheModel = static_cast<CacheModel>(cacheModel);
> +	   platformSetCacheModel(static_cast<CacheModel>(cacheModel));
>      }
>  }

I still think a local variable with type CacheModel would be better.