[webkit-reviews] review denied: [Bug 47090] Don't use GtkObject : [Attachment 69638] Do not use GtkObject

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied  review:
Bug 47090: Don't use GtkObject
https://bugs.webkit.org/show_bug.cgi?id=47090

Attachment 69638: Do not use GtkObject
https://bugs.webkit.org/attachment.cgi?id=69638&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69638&action=review

This change needs a ChangeLog. :) Check the WebKit contributing page for some
handy shortcuts wrt to ChangeLogs:
http://webkit.org/coding/contributing.html#changelogs

> WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp:550
> +#if GTK_CHECK_VERSION (2, 90, 8)
> +    GtkAdjustment* adjustment = gtk_adjustment_new(0.0, 0.0, 100.0, 0.1,
1.0, 1.0);
> +#else
> +    GtkAdjustment* adjustment = GTK_ADJUSTMENT(gtk_adjustment_new(0.0, 0.0,
100.0, 0.1, 1.0, 1.0));
> +#endif
> +    m_timeHScale = gtk_hscale_new(adjustment);
>      gtk_scale_set_draw_value(GTK_SCALE(m_timeHScale), FALSE);

I think in this case, the extra cast is worth getting preventing #ifdefs here.