[webkit-reviews] review granted: [Bug 47035] Application cache selection algorithm should only be invoked after navigation : [Attachment 69663] with Qt build fix

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 47035: Application cache selection algorithm should only be invoked after
navigation
https://bugs.webkit.org/show_bug.cgi?id=47035

Attachment 69663: with Qt build fix
https://bugs.webkit.org/attachment.cgi?id=69663&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69663&action=review

I'm not super happy with how the bit ends up getting set on the parser, but I'm
not sure I have a better idea for how to do it.  Thanks for iterating on the
patch.

> WebCore/html/ImageDocument.cpp:200
>      RefPtr<Element> rootElement = Document::createElement(htmlTag, false);
>      appendChild(rootElement, ec);
> +#if ENABLE(OFFLINE_WEB_APPLICATIONS)
> +    static_cast<HTMLHtmlElement*>(rootElement.get())->insertedByParser();
> +#endif

I should clean up all this stuff to go through the HTMLDocumentParser.

> WebCore/html/parser/HTMLConstructionSite.h:-57
> -    void insertHTMLHtmlElement(AtomicHTMLToken&);

I take it this was unused.

> WebCore/loader/DocumentWriter.cpp:254
> +void DocumentWriter::setDocumentWasLoadedAsPartOfNavigation()
> +{
> +    m_frame->document()->parser()->setDocumentWasLoadedAsPartOfNavigation();

> +}

This does kind of look silly.  :)