[webkit-reviews] review denied: [Bug 47007] ARMv7 JIT should take advantage of 2-byte branches to reduce code size : [Attachment 69656] Updated patch addressing reviewer comments.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 4 11:58:44 PDT 2010
Oliver Hunt <oliver at apple.com> has denied David Goodwin
<david_goodwin at apple.com>'s request for review:
Bug 47007: ARMv7 JIT should take advantage of 2-byte branches to reduce code
size
https://bugs.webkit.org/show_bug.cgi?id=47007
Attachment 69656: Updated patch addressing reviewer comments.
https://bugs.webkit.org/attachment.cgi?id=69656&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69656&action=review
Just those two changes and then i'll r and cq+ this
> JavaScriptCore/assembler/ARMv7Assembler.h:2
> + * Copyright (C) 2009,2010 Apple Inc. All rights reserved.
should be a space here
> JavaScriptCore/assembler/ARMv7Assembler.h:1750
> + ASSERT(false);
This should be ASSERT_NOT_REACHED();
More information about the webkit-reviews
mailing list