[webkit-reviews] review denied: [Bug 47078] [Chromium] DeviceMotion plumbing : [Attachment 69625] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 47078: [Chromium] DeviceMotion plumbing
https://bugs.webkit.org/show_bug.cgi?id=47078

Attachment 69625: Patch
https://bugs.webkit.org/attachment.cgi?id=69625&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69625&action=review

> WebKit/chromium/public/WebDeviceMotionData.h:42
> +    WEBKIT_API static WebDeviceMotionData* create(bool
canProvideXAcceleration, double xAcceleration,

why heap allocated?

normally, when we use WebPrivatePtr to implement a type, it means that we
provide a constructor, destructor, initialize, reset, assign, etc. methods.
please see WebNode for an example.