[webkit-reviews] review granted: [Bug 47066] Add ability to set the CacheModel in Webkit2 : [Attachment 69597] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 4 10:11:46 PDT 2010


Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 47066: Add ability to set the CacheModel in Webkit2
https://bugs.webkit.org/show_bug.cgi?id=47066

Attachment 69597: Patch
https://bugs.webkit.org/attachment.cgi?id=69597&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69597&action=review

I don't see you adding WebProcessQt to the relevant build system, please do
that too.

> WebKit2/WebProcess/mac/WebProcessMac.mm:233
> +    printf("Page Cache: %d\n", pageCache()->capacity());

Please don't check this in.


More information about the webkit-reviews mailing list