[webkit-reviews] review denied: [Bug 46873] Rename @webkitspeech to @x-webkit-speech to follow HTML5 convention : [Attachment 69334] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Satish Sampath
<satish at chromium.org>'s request for review:
Bug 46873: Rename @webkitspeech to @x-webkit-speech to follow HTML5 convention
https://bugs.webkit.org/show_bug.cgi?id=46873

Attachment 69334: Patch
https://bugs.webkit.org/attachment.cgi?id=69334&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69334&action=review

> WebCore/dom/make_names.pl:187
> +    if ($attr =~ m/^x-webkit/) {

Maybe do m/^x-webkit-(.*)/ and then use the $1 as the attribute?

> WebCore/dom/make_names.pl:193
> +	   $attr =~ s/-/_/g;

You probably want this in both code paths, right?