[webkit-reviews] review granted: [Bug 47076] [cairo] Move some cairo functions to the CairoUtilities : [Attachment 69613] Proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 47076: [cairo] Move some cairo functions to the CairoUtilities
https://bugs.webkit.org/show_bug.cgi?id=47076

Attachment 69613: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=69613&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69613&action=review

Looks great! Please fix the following small issues before landing though.

> WebCore/platform/graphics/cairo/CairoUtilities.cpp:73
> +// We apply the pending path built via addPath to the Cairo context
> +// lazily. This prevents interaction between the path and other routines
> +// such as fillRect.

This comment doesn't make quite as much sense now that this function is shared
between different source files. It's probably safe just to remove it.

> WebCore/platform/graphics/cairo/CairoUtilities.cpp:122
> +void drawPatternCairo(cairo_t* cr, cairo_surface_t* image, const IntSize&
imageSize, const FloatRect& tileRect,

I think it you should call this drawPatternToCairoContext to match the name of
the other helper functions.