[webkit-reviews] review denied: [Bug 45825] Web Inspector: Factor out InspectorCSSAgent : [Attachment 69484] [PATCH] Preliminary patch style fixed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 4 03:25:38 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 45825: Web Inspector: Factor out InspectorCSSAgent
https://bugs.webkit.org/show_bug.cgi?id=45825
Attachment 69484: [PATCH] Preliminary patch style fixed
https://bugs.webkit.org/attachment.cgi?id=69484&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69484&action=review
Could you please submit a change with new InspectorStyleSheet and
InspectorCSSAgent components. I believe rest if orthogonal to the change.
> WebCore/inspector/InspectorCSSAgent.h:92
> +class InspectorStyleSheet : public RefCounted<InspectorStyleSheet> {
InspectorStyleSheet should be defined in its own class.
> WebCore/inspector/InspectorUtilities.h:50
> + static CSSStyleSheet* parentStyleSheet(StyleBase*);
CSS-specific utilities should belong to InspectorCSSAgent.
More information about the webkit-reviews
mailing list