[webkit-reviews] review granted: [Bug 46058] Add infrastructure towards detecting change log diffs that aren't at the top of the ChangeLog : [Attachment 68036] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 46058: Add infrastructure towards detecting change log diffs that aren't at
the top of the ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=46058

Attachment 68036: Patch
https://bugs.webkit.org/attachment.cgi?id=68036&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68036&action=review

> WebKitTools/Scripts/VCSUtils.pm:1575
> +	   my $changeLog = fixChangeLogPatch($patch);

Variable name should note it's a reference to a hash.  Maybe $changeLogHash.

> WebKitTools/Scripts/svn-apply:319
> +	       my $changeLog = fixChangeLogPatch($patch);

Ditto.

> WebKitTools/Scripts/svn-create-patch:236
> +	   my $changeLog = fixChangeLogPatch($patch);

Ditto.

> WebKitTools/Scripts/svn-unapply:161
> +	       my $changeLog = fixChangeLogPatch($patch);

Ditto.

> WebKitTools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:4
> +# Copyright (C) Research in Motion Limited 2010. All Rights Reserved.

Shouldn't the year of the copyright be after the "(C)"?

r=me with the variable name changes.