[webkit-reviews] review granted: [Bug 47055] All the WebSocket tests crash : [Attachment 69583] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 3 01:13:31 PDT 2010


Holger Freyther <zecke at selfish.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 47055: All the WebSocket tests crash
https://bugs.webkit.org/show_bug.cgi?id=47055

Attachment 69583: Patch
https://bugs.webkit.org/attachment.cgi?id=69583&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69583&action=review

You could keep the 'const'. The patch looks sane.

> WebCore/ChangeLog:9
> +	   That doesn't work in C++.  Instead, we need to actually store the

You could remove the extra space.


More information about the webkit-reviews mailing list