[webkit-reviews] review denied: [Bug 47052] [Qt] Hook up DeviceOrientation data for Qt support : [Attachment 69577] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 47052: [Qt] Hook up DeviceOrientation data for Qt support
https://bugs.webkit.org/show_bug.cgi?id=47052

Attachment 69577: Patch
https://bugs.webkit.org/attachment.cgi?id=69577&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69577&action=review

> WebCore/WebCore.pro:3266
> +	   ../WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.h \

None of this depends directly on QtMobility?

> WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.cpp:41
> +    m_provider = 0;
> +    delete m_provider;

This is wrong! you are leaking!

> WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.cpp:72
> +    if (m_controller)
> +	   m_controller->didChangeDeviceOrientation(orientation);

I like the following more

if (!m_controller)
    return;

m_controller->...