[webkit-reviews] review granted: [Bug 46790] GStreamer PlatformVideoWindow needs an API to prepare the widget before applying the overlay : [Attachment 69176] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 46790: GStreamer PlatformVideoWindow needs an API to prepare the widget
before applying the overlay
https://bugs.webkit.org/show_bug.cgi?id=46790

Attachment 69176: proposed patch
https://bugs.webkit.org/attachment.cgi?id=69176&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69176&action=review

I'm not sure what an appropriate name for this method should be (perhaps
prepareForOverlay?), but I think that prepare is not descriptive enough.

> WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:198
> +	   m_videoWindow->prepare(message);

The name prepare(...) seems a little ambiguous. I would prefer something a bit
more descriptive.

> WebCore/platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp:40
> +    notImplemented();

An empty implementation is different than notImplemented(). This should just be
empty.

> WebCore/platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:69
> +    notImplemented();

Same here.