[webkit-reviews] review granted: [Bug 47020] Fixing crash when audio media player is destructed : [Attachment 69533] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Victoria Kirst
<vrk at google.com>'s request for review:
Bug 47020: Fixing crash when audio media player is destructed
https://bugs.webkit.org/show_bug.cgi?id=47020

Attachment 69533: Patch
https://bugs.webkit.org/attachment.cgi?id=69533&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69533&action=review

R=me

> WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:190
> +    if (!layerRenderer())
> +	   return;
> +

If we expect this never to be the case, it's probably better to add an ASSERT()
instead and watch for issues in the field.  We don't want to paper over real
bugs if we don't understand how they might be happening.