[webkit-reviews] review granted: [Bug 47021] Patch the floatBottom function and its friends. : [Attachment 69526] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 47021: Patch the floatBottom function and its friends.
https://bugs.webkit.org/show_bug.cgi?id=47021

Attachment 69526: Patch
https://bugs.webkit.org/attachment.cgi?id=69526&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=69526&action=review

> WebCore/rendering/RenderBlock.cpp:3296
> -int
> -RenderBlock::floatBottom() const
> +int RenderBlock::lowestFloatLogicalBottom(FloatingObject::Type floatType)
const

Finally!

> WebCore/rendering/RenderBlock.cpp:3304
> +	   if (r->type() & floatType)

Kind of ugly. I’d like at least to see a comment about the definition of the
FloatingObject::Type enum saying that it’s a bitfield.