[webkit-reviews] review denied: [Bug 46765] Render textures directly in VideoFrameChromium : [Attachment 69284] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 46765: Render textures directly in VideoFrameChromium
https://bugs.webkit.org/show_bug.cgi?id=46765

Attachment 69284: Patch
https://bugs.webkit.org/attachment.cgi?id=69284&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69284&action=review

> WebCore/ChangeLog:4
> +	   Reviewed by NOBODY (OOPS!).
> +

This needs a one-line patch description (usually the bug title) and a link to
the bug

> WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:257
> +
> +    // FIXME: If surface type is GL texture we should call putCurrentFrame()
only after swap buffers happened.
>      m_provider->putCurrentFrame(frame);

I think this goes away now

> WebKit/chromium/public/WebVideoFrame.h:56
> +	   SurfaceTypeGlTexture,

This should probably match the other SurfaceType enum (i.e. not have 'Gl').