[webkit-reviews] review denied: [Bug 47020] Fixing crash when audio media player is destructed : [Attachment 69521] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Victoria Kirst
<vrk at google.com>'s request for review:
Bug 47020: Fixing crash when audio media player is destructed
https://bugs.webkit.org/show_bug.cgi?id=47020

Attachment 69521: Patch
https://bugs.webkit.org/attachment.cgi?id=69521&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69521&action=review

r- for mangled ChangeLog.  Any chance of a test?  When will the layerRenderer()
test fail?

> WebCore/ChangeLog:22
> +2010-10-01  Victoria Kirst  <vrk at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Makes check in destructor to see if renderer was hooked up to the
> +	   layer before destructing object.
> +
> +	   * platform/graphics/chromium/VideoLayerChromium.cpp:
> +	   (WebCore::VideoLayerChromium::~VideoLayerChromium):
> +
> +2010-10-01  Victoria Kirst  <vrk at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Fixing crash when audio media player is destructed
> +	   https://bugs.webkit.org/show_bug.cgi?id=47020
> +
> +	   No new tests. (OOPS!)
> +
> +	   * platform/graphics/chromium/VideoLayerChromium.cpp:
> +	   (WebCore::VideoLayerChromium::~VideoLayerChromium):
> +

Looks like you ran prepare-ChangeLogs twice.  Please resolve.