[webkit-reviews] review granted: [Bug 42580] DOMFocusIn/DOMFocusOut return focusin/focusout Event.type : [Attachment 69503] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 42580: DOMFocusIn/DOMFocusOut return focusin/focusout Event.type
https://bugs.webkit.org/show_bug.cgi?id=42580

Attachment 69503: Patch
https://bugs.webkit.org/attachment.cgi?id=69503&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69503&action=review

> WebCore/dom/Document.cpp:3108
> +	   // FIXME: We should remove firing the old event in the future.

I’m not sure “the old event” and “in the future” are clear enough. A better
comment would be more specific that DOMFocusOut is “the old event” and use
wording that talks specifically about when this would be appropriate. For
example we could say, “when we are sure no content depends on it”, and perhaps
even mention the Mail issue or point to a bug number that mentions that. We
want the FIXME to be actionable.

> LayoutTests/fast/events/focusinout.html:22
> +	   writeFailed('result1', "Wrong even type");

Typo: "even type" instead of "event type". Same typo in all three places.