[webkit-reviews] review granted: [Bug 46937] [chromium] Minor naming cleanup in WebDragData : [Attachment 69485] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 46937: [chromium] Minor naming cleanup in WebDragData
https://bugs.webkit.org/show_bug.cgi?id=46937

Attachment 69485: Patch
https://bugs.webkit.org/attachment.cgi?id=69485&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69485&action=review

> WebKit/chromium/ChangeLog:14
> +	   The list of methods that have been renamed:
> +	   * hasFileNames() -> containsFilenames()
> +	   * fileNames() -> filenames()

I think Ryosuke was saying that you can put this in the section below.	The :
after the method names is supposed to be space to write comments about how you
modified the method.

> WebKit/chromium/ChangeLog:22
> +	   (WebKit::WebDragData::hasFileNames):

For example, here you would write "(WebKit::WebDragData::hasFileNames): renamed
to containsFilenames"

> WebKit/chromium/public/WebDragData.h:84
>      WEBKIT_API void setFileNames(const WebVector<WebString>&);
>      WEBKIT_API void appendToFileNames(const WebString&);

Nit: Can you add a comment that these methods are deprecated/obsolete?