[webkit-reviews] review granted: [Bug 46992] Implement NPN_GetValueForURL/NPN_SetValueForURL and stub out PluginController functions : [Attachment 69477] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 46992: Implement NPN_GetValueForURL/NPN_SetValueForURL and stub out
PluginController functions
https://bugs.webkit.org/show_bug.cgi?id=46992

Attachment 69477: Patch
https://bugs.webkit.org/attachment.cgi?id=69477&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=69477&action=review

> WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:80
> +    String proxiesForURL(const String& urlString);
> +    String cookiesForURL(const String& urlString);

No need to name the argument in these two.

> WebKit2/WebProcess/Plugins/PluginController.h:96
> +    virtual String proxiesForURL(const String& urlString) = 0;
> +
> +    // Returns the cookies for the given URL or null on failure.
> +    virtual String cookiesForURL(const String& urlString) = 0;
> +

No need to name the arguments in these two.

> WebKit2/WebProcess/Plugins/PluginView.h:131
> +    virtual String proxiesForURL(const String& urlString);
> +    virtual String cookiesForURL(const String& urlString);

No need to name the arguments here.