[webkit-reviews] review granted: [Bug 46960] Specify ALWAYS_INLINE at function declaration not function definition : [Attachment 69426] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 46960: Specify ALWAYS_INLINE at function declaration not function
definition
https://bugs.webkit.org/show_bug.cgi?id=46960

Attachment 69426: Patch
https://bugs.webkit.org/attachment.cgi?id=69426&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Consider these docs:

http://gcc.gnu.org/onlinedocs/gcc/Inline.html
http://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Attribute-Syntax.html#Attribute-Syn
tax
http://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Function-Attributes.html

I'm pretty sure that ALWAYS_INLINE is only needed at the declaration site, not
the definition site.

Even so, this patch is good, so r=me.