[webkit-reviews] review requested: [Bug 45532] Rewrite SVG text layout code : [Attachment 69467] Patch: WebCore - v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 1 07:50:35 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 45532: Rewrite SVG text layout code
https://bugs.webkit.org/show_bug.cgi?id=45532

Attachment 69467: Patch: WebCore - v2
https://bugs.webkit.org/attachment.cgi?id=69467&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
This time with an extensive ChangeLog.
The LayoutTests side of this patch follows soon.

NOTE: Dirk has already reviewed my work during the last weeks, otherwhise I
wouldn't have asked him to review this beast.
I already splitted the patch up before (see the depends section), but I
couldn't split this thing up any further, without landing #if 0 code or lots of
commented stuff with FIXMEs.
Text is really a hairy section, and when changing underlying core concepts
(like removing text chunks & text chunk parts), this affects several hundred k
of code.


More information about the webkit-reviews mailing list