[webkit-reviews] review granted: [Bug 45954] Web Inspector: [Extensions API] expose page load events timings : [Attachment 69453] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 1 06:04:27 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 45954: Web Inspector: [Extensions API] expose page load events timings
https://bugs.webkit.org/show_bug.cgi?id=45954

Attachment 69453: patch
https://bugs.webkit.org/attachment.cgi?id=69453&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69453&action=review

> WebCore/inspector/front-end/inspector.js:1297
> +	   if (resource.mainResource) {

This looks confusing. Load time should be sent to the front-end after the main
resource has been loaded. It is just that we are using a hack to pass page load
timing along with the main resource data.


More information about the webkit-reviews mailing list