[webkit-reviews] review granted: [Bug 46979] [WINCE] Use alphaBlendIfSupported in GraphicsContext : [Attachment 69456] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 1 05:52:28 PDT 2010
Adam Roben (aroben) <aroben at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 46979: [WINCE] Use alphaBlendIfSupported in GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=46979
Attachment 69456: Patch
https://bugs.webkit.org/attachment.cgi?id=69456&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69456&action=review
> WebCore/platform/graphics/wince/GraphicsContextWinCE.cpp:341
> + if (!alphaBlendIfSupported(m_dc, origRect.x(), origRect.y(),
origRect.width(), origRect.height(), hdc, 0, 0, bmpRect.right, bmpRect.bottom,
blend))
> + ASSERT_NOT_REACHED();
Another way to do this without a branch is:
bool success = alphaBlendIfSupported(...);
ASSERT_UNUSED(success, success);
More information about the webkit-reviews
mailing list