[webkit-reviews] review denied: [Bug 46259] [Qt] QNetworkReplyHandler forces buffered output for FormData with files : [Attachment 69445] Fix style and EWS errors

[bugzilla-daemon at webkit.org]

Andreas Kling <andreas.kling at nokia.com> has denied Sriram Neelakandan
<sriram.neelakandan at gmail.com>'s request for review:
Bug 46259: [Qt] QNetworkReplyHandler forces buffered output for FormData with
files
https://bugs.webkit.org/show_bug.cgi?id=46259

Attachment 69445: Fix style and EWS errors
https://bugs.webkit.org/attachment.cgi?id=69445&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69445&action=review

Close, but not quite there yet.

> WebCore/platform/network/qt/QNetworkReplyHandler.cpp:88
> +	   if (element.m_type == FormDataElement::data) 
> +	       m_dataSize += element.m_data.size();
> +	   else {
> +	       QFileInfo fi(element.m_filename);
> +	       m_fileSize += fi.size();
> +	   }

If building with ENABLE(BLOB), this fails to take FormDataElement::encodedBlob
into account. (see FormData.h)

> WebCore/platform/network/qt/QNetworkReplyHandler.cpp:92
> +#ifdef QT_NETWORK_DEBUG
> +    qDebug() << __PRETTY_FUNCTION__ << "FileSize=" << m_fileSize <<
"DataSize=" << m_dataSize;
> +#endif

Please remove this.
This kind of output should only be added for things that are non-trivial to do
using a debugger.

> WebCore/platform/network/qt/QNetworkReplyHandler.h:100
> +    qint64 getFormDataSize() const { return m_totalSize; }

You don't need the m_totalSize member, just "return m_dataSize + m_fileSize;"