[webkit-reviews] review denied: [Bug 46051] SVG: Make RenderPath DRT output platform-independent : [Attachment 68073] Proposed patch v2

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 46051: SVG: Make RenderPath DRT output platform-independent
https://bugs.webkit.org/show_bug.cgi?id=46051

Attachment 68073: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=68073&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
As discussed on IRC, the right way to go is to introduce a RenderSVGShape class
whose repaintRectInLocalCoordinates can be dumped.
The problem is that dumping RenderPath::repaintRectInLocalCoordinates, is that
it's platform-dependant, as Path::boundingBox is used.

As first step, I'd introduce RenderSVGShape : public RenderPath (which should
be renamed and moved to rendering/svg/RenderSVGPath first)
and let SVGCircle/RectElement etc. create RenderSVGShape instead of
RenderSVGPath.

Once that's done, we need to introduce platform-dependant ways to create rects,
circles, instead of the home-brewn code in Path.cpp (addEllipse, etc.)
Then we need to write a method which calculates the circle/rect/etc. boundaries
in a _cross platform_ fashion.

Then RenderSVGShape can use this new logic, and inherit from
RenderSVGModelObject, and be completly decoupled from RenderSVGPath.
Once that's done the DRT problem vanishes.

(This is just a short summary of the IRC discussion).