[webkit-reviews] review granted: [Bug 50302] Text search should treat all matches as word-start matches when the target begins with a separator character : [Attachment 75237] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 50302: Text search should treat all matches as word-start matches when the
target begins with a separator character
https://bugs.webkit.org/show_bug.cgi?id=50302

Attachment 75237: Patch
https://bugs.webkit.org/attachment.cgi?id=75237&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75237&action=review

> WebCore/editing/TextIterator.cpp:1897
> +    if (m_options & AtWordStarts && targetLength) {
> +	   UChar32 targetFirstCharacter;
> +	   U16_GET(m_target.characters(), 0, 0, m_target.length(),
targetFirstCharacter);

You probably need parentheses to avoid annoying newest gcc.

Why not use targetLength here instead of m_target.length()?

> WebCore/editing/TextIterator.cpp:1898
> +	   // Characters in the separator category are never really occur at
the beginning of a word,

"are never really occur" is wrong -- I suggest removing a word