[webkit-reviews] review denied: [Bug 50270] [Qt] [Symbian] Reintroduce compiler optimizations for JSC : [Attachment 75201] Patch that adds optimization to JavaScriptCore lib

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 30 14:30:33 PST 2010


Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 50270: [Qt] [Symbian] Reintroduce compiler optimizations for JSC
https://bugs.webkit.org/show_bug.cgi?id=50270

Attachment 75201: Patch that adds optimization to JavaScriptCore lib
https://bugs.webkit.org/attachment.cgi?id=75201&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75201&action=review

> JavaScriptCore/ChangeLog:8
> +

ChangeLog should follow the style - see
http://webkit.org/coding/contributing.html#changelogs.

It should look like:
[Qt] [Symbian] Reintroduce compiler optimizations for JSC
https://bugs.webkit.org/show_bug.cgi?id=50270

Add compiler optimization (symbian ARM target) which was lost after split from
WebCore.
Tested via Sunspider and V8 - both of which show significant performance
improvement.


Otherwise patch looks good to me, but I would like to see more discussion on if
we can remove the optimizations from WebCore.


More information about the webkit-reviews mailing list