[webkit-reviews] review granted: [Bug 50204] REGRESSION(r72861): editing/selection/click-left-of-rtl-wrapping-text.html and modify-up-on-rtl-wrapping-text.html fail on all but Mac platform : [Attachment 75184] fixed more

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 50204: REGRESSION(r72861):
editing/selection/click-left-of-rtl-wrapping-text.html and
modify-up-on-rtl-wrapping-text.html fail on all but Mac platform
https://bugs.webkit.org/show_bug.cgi?id=50204

Attachment 75184: fixed more
https://bugs.webkit.org/attachment.cgi?id=75184&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75184&action=review

> LayoutTests/editing/selection/click-left-of-rtl-wrapping-text.html:35
> +    var heightOfLine = container.offsetHeight;
> +    var width = 5;
> +    do {
> +	   container.style.width = width + 'px';
> +	   width++;
> +    } while (container.offsetHeight > heightOfLine * test.expected.length); 
      
> +    container.style.width = (width + 1) + 'px';

Please add a comment here and in the test below explaining why you're doing
this. Just the same thing you told me in person.