[webkit-reviews] review granted: [Bug 50183] Erroneously commented out code in RenderBlock::layoutPositionedObjects() : [Attachment 75176] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 30 11:46:37 PST 2010


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 50183: Erroneously commented out code in
RenderBlock::layoutPositionedObjects()
https://bugs.webkit.org/show_bug.cgi?id=50183

Attachment 75176: Patch
https://bugs.webkit.org/attachment.cgi?id=75176&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75176&action=review

> WebCore/rendering/RenderBlock.cpp:4734
> +	       if (!layer()->verticalScrollbar())
> +		   layer()->setHasVerticalScrollbar(true);

You could call setHasVerticalScrollbar() unconditionally; it does no work if
there's already a vertical scrollbar.

> WebCore/rendering/RenderFlexibleBox.cpp:185
> +	   if (!layer()->verticalScrollbar())
> +	       layer()->setHasVerticalScrollbar(true);

Ditto.


More information about the webkit-reviews mailing list