[webkit-reviews] review denied: [Bug 50223] Web Inspector: refactor SourceFrame to simplify implementing of js beautifier : [Attachment 75121] Patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 50223: Web Inspector: refactor SourceFrame to simplify implementing of js
beautifier
https://bugs.webkit.org/show_bug.cgi?id=50223

Attachment 75121: Patch.
https://bugs.webkit.org/attachment.cgi?id=75121&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75121&action=review

I really don't see how this is better than what we have today. Why do you think
it helps with the beautification?

> WebCore/inspector/front-end/ScriptView.js:95
> +    _getSourceIDs: function()

WebCore does not use get prefix for getters.

> WebCore/inspector/front-end/SourceFrame.js:181
> +    hasTextViewer: function()

SourceFrame should not expose textViewer notion outside itself and should
entirely encapsulate viewer together with its lazy initialization business.