[webkit-reviews] review granted: [Bug 49581] Cleanup UTF8.cpp : [Attachment 74476] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 30 10:37:39 PST 2010


Darin Adler <darin at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 49581: Cleanup UTF8.cpp
https://bugs.webkit.org/show_bug.cgi?id=49581

Attachment 74476: Patch
https://bugs.webkit.org/attachment.cgi?id=74476&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74476&action=review

> JavaScriptCore/wtf/unicode/UTF8.cpp:35
> +const UChar replacementCharacter = 0xFFFD;

Since this is inside a .cpp file we should use static to give it internal
linkage.


More information about the webkit-reviews mailing list