[webkit-reviews] review denied: [Bug 50204] REGRESSION(r72861): editing/selection/click-left-of-rtl-wrapping-text.html and modify-up-on-rtl-wrapping-text.html fail on all but Mac platform : [Attachment 75108] fixes the tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 30 08:07:34 PST 2010


Ojan Vafai <ojan at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 50204: REGRESSION(r72861):
editing/selection/click-left-of-rtl-wrapping-text.html and
modify-up-on-rtl-wrapping-text.html fail on all but Mac platform
https://bugs.webkit.org/show_bug.cgi?id=50204

Attachment 75108: fixes the tests
https://bugs.webkit.org/attachment.cgi?id=75108&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75108&action=review

> LayoutTests/editing/selection/click-left-of-rtl-wrapping-text.html:30
> +    for (var i = 5; i == 5 || container.offsetHeight > heightOfLine *
test.expected.length; i++)

I don't understand this for loop. i starts and 5 and checks for == 5 ?


More information about the webkit-reviews mailing list