[webkit-reviews] review denied: [Bug 50233] Remove unnecessary pixel results, use platform-independent text results, re Changeset 72802 : [Attachment 75137] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 30 07:44:08 PST 2010


Ojan Vafai <ojan at chromium.org> has denied W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 50233: Remove unnecessary pixel results, use platform-independent text
results, re Changeset 72802
https://bugs.webkit.org/show_bug.cgi?id=50233

Attachment 75137: Patch
https://bugs.webkit.org/attachment.cgi?id=75137&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Thanks for doing this. In order to avoid needing pixel results, you need to
explicitly mark each test as dumpAsText (see
http://webkit.org/quality/testwriting.html). Examples:
http://codesearch.google.com/codesearch?as_q=dumpAsText&vert=chromium&as_lang=j
avascript

Also, please delete the chromium-mac and chromium-win pixel results for these
tests as well.


More information about the webkit-reviews mailing list